Skip to content

Fix pre-commit step in CI #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix pre-commit step in CI #929

merged 3 commits into from
Jan 10, 2025

Conversation

@YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jan 9, 2025 •
edited
Loading

What do these changes do?

  • There was a bug introduced in hook. The fix comes in a later version
  • Use pre-commit github native action

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review January 10, 2025 07:41
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 10, 2025
@YuryHrytsuk YuryHrytsuk added this to the Event Horizon milestone Jan 10, 2025
mrnicegyu11
mrnicegyu11 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, perfect

@YuryHrytsuk YuryHrytsuk merged commit 6498f00 into ITISFoundation:main Jan 10, 2025
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the fix-ci-pre-commit branch January 10, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

FAST p:high-prio

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

2 participants

@YuryHrytsuk @mrnicegyu11